chore: drop bluebird and lodash#57
Merged
eglitise merged 3 commits intoappium:masterfrom Jan 22, 2026
Merged
Conversation
lib/asyncbox.ts
Outdated
| }); | ||
| const debug = opts.logger ? opts.logger.debug.bind(opts.logger) : _.noop; | ||
| const opts: WaitForConditionOptions & {waitMs: number; intervalMs: number} = Object.assign( | ||
| {waitMs: 5000, intervalMs: 500}, |
Contributor
There was a problem hiding this comment.
this is not exactly the same replacement as before. defaults API also properly handles undefined values, so a better alternative would be
{
waitMs: options.waitMs ?? 5000,
intervalMs: options.intervalMs ?? 500,
}
Contributor
Author
There was a problem hiding this comment.
Added guard for non-numerical values
KazuCocoa
approved these changes
Jan 22, 2026
| "build/lib/**/*" | ||
| ], | ||
| "dependencies": { | ||
| "bluebird": "^3.5.1", |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
## [6.0.1](v6.0.0...v6.0.1) (2026-01-22) ### Miscellaneous Chores * drop bluebird and lodash ([#57](#57)) ([c25537b](c25537b))
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces all remaining uses of
bluebirdandlodashwith native (and more performant) alternatives.While lodash (unlike bluebird) is still maintained, the key factor for dropping it here is that
asyncboxis a small utility module, and I believe such modules should be kept as slim as possible, with few to no external dependencies. None of the used lodash functions were also particularly complex, and could easily be replaced without sacrificing readability.