Optimize ToDictionary() for improved performance in PointerInputDevice#1026
Open
Dor-bl wants to merge 3 commits intoappium:mainfrom
Open
Optimize ToDictionary() for improved performance in PointerInputDevice#1026Dor-bl wants to merge 3 commits intoappium:mainfrom
Dor-bl wants to merge 3 commits intoappium:mainfrom
Conversation
Replace LINQ ToList().ForEach() with a standard foreach loop when appending extra attributes. This avoids an unnecessary O(N) memory allocation and improves execution speed for dictionary translation.
Replace LINQ ToList().ForEach() with a standard foreach loop when appending extra attributes. This avoids an unnecessary O(N) memory allocation and improves execution speed for dictionary translation.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes how PointerInputDevice merges extra pointer attributes into the wrapped interaction payload by avoiding an intermediate LINQ allocation.
Changes:
- Replaced
ToList().ForEach(...)with aforeachloop when copyingpointerInputExtraAttributesinto the output dictionary.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Please provide a briefly described change list that you are going to propose.
Types of changes
What types of changes are you proposing/introducing to the .NET client?
Put an
xin the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub