Skip to content

test: add iOS category attribute to multiple test classes#1033

Open
Dor-bl wants to merge 1 commit intoappium:mainfrom
Dor-bl:ios-test-category
Open

test: add iOS category attribute to multiple test classes#1033
Dor-bl wants to merge 1 commit intoappium:mainfrom
Dor-bl:ios-test-category

Conversation

@Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Mar 27, 2026

List of changes

This pull request adds the [Category("iOS")] attribute to all iOS integration test classes. This change standardizes test categorization, making it easier to run or filter iOS-specific tests in the test suite.

Test Categorization Improvements:

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Test fix (non-breaking change that improves test stability or correctness)

Documentation

  • Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes NUnit test filtering for the iOS integration test suite by applying an iOS category at the test-class level.

Changes:

  • Added [Category("iOS")] to all iOS integration test classes (including Device and Session subfolders).
  • Added [TestFixture] to a couple of iOS internal test classes while adding the iOS category.
  • Removed a couple of unused using directives in iOS test files touched by the change.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/integration/IOS/WebviewTest.cs Adds iOS category to the WebView integration test fixture.
test/integration/IOS/SettingTest.cs Adds iOS category to settings integration tests.
test/integration/IOS/Session/LogTests.cs Adds iOS category (and adds [TestFixture]) for iOS log/session tests.
test/integration/IOS/SearchingTest.cs Adds iOS category to searching integration tests.
test/integration/IOS/SearchingClassChainTest.cs Adds iOS category to class-chain searching tests.
test/integration/IOS/ScrollingSearchingTest.cs Adds iOS category to scrolling/searching tests.
test/integration/IOS/ScreenRecordingTest.cs Adds iOS category and removes an unused using.
test/integration/IOS/OrientationTest.cs Adds iOS category to orientation tests.
test/integration/IOS/LockDeviceTest.cs Adds iOS category to lock/unlock device tests.
test/integration/IOS/ElementTest.cs Adds iOS category to element interaction tests.
test/integration/IOS/Device/SystemTests.cs Adds iOS category to iOS device system tests.
test/integration/IOS/Device/KeyboardTests.cs Adds iOS category and removes an unused using.
test/integration/IOS/Device/AppTests.cs Adds iOS category (and adds [TestFixture]) to iOS device app tests.
test/integration/IOS/ClipboardTest.cs Adds iOS category alongside existing Device categorization.
test/integration/IOS/AppStringsTest.cs Adds iOS category to app strings tests.
test/integration/IOS/AlertTests.cs Adds iOS category to alert tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{
[TestFixture]
[Category("iOS")]

Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s an extra blank line between the attribute block and the class declaration. Consider removing it to keep formatting consistent with the other iOS test fixtures in this folder.

Suggested change

Copilot uses AI. Check for mistakes.
{
[TestFixture(Category = "Device")]
[Category("iOS")]

Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s an extra blank line between the attribute block and the class declaration. Consider removing it to keep formatting consistent with the other iOS test fixtures.

Suggested change

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants