test: add iOS category attribute to multiple test classes#1033
test: add iOS category attribute to multiple test classes#1033Dor-bl wants to merge 1 commit intoappium:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes NUnit test filtering for the iOS integration test suite by applying an iOS category at the test-class level.
Changes:
- Added
[Category("iOS")]to all iOS integration test classes (includingDeviceandSessionsubfolders). - Added
[TestFixture]to a couple of iOS internal test classes while adding the iOS category. - Removed a couple of unused
usingdirectives in iOS test files touched by the change.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/IOS/WebviewTest.cs | Adds iOS category to the WebView integration test fixture. |
| test/integration/IOS/SettingTest.cs | Adds iOS category to settings integration tests. |
| test/integration/IOS/Session/LogTests.cs | Adds iOS category (and adds [TestFixture]) for iOS log/session tests. |
| test/integration/IOS/SearchingTest.cs | Adds iOS category to searching integration tests. |
| test/integration/IOS/SearchingClassChainTest.cs | Adds iOS category to class-chain searching tests. |
| test/integration/IOS/ScrollingSearchingTest.cs | Adds iOS category to scrolling/searching tests. |
| test/integration/IOS/ScreenRecordingTest.cs | Adds iOS category and removes an unused using. |
| test/integration/IOS/OrientationTest.cs | Adds iOS category to orientation tests. |
| test/integration/IOS/LockDeviceTest.cs | Adds iOS category to lock/unlock device tests. |
| test/integration/IOS/ElementTest.cs | Adds iOS category to element interaction tests. |
| test/integration/IOS/Device/SystemTests.cs | Adds iOS category to iOS device system tests. |
| test/integration/IOS/Device/KeyboardTests.cs | Adds iOS category and removes an unused using. |
| test/integration/IOS/Device/AppTests.cs | Adds iOS category (and adds [TestFixture]) to iOS device app tests. |
| test/integration/IOS/ClipboardTest.cs | Adds iOS category alongside existing Device categorization. |
| test/integration/IOS/AppStringsTest.cs | Adds iOS category to app strings tests. |
| test/integration/IOS/AlertTests.cs | Adds iOS category to alert tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| [TestFixture] | ||
| [Category("iOS")] | ||
|
|
There was a problem hiding this comment.
There’s an extra blank line between the attribute block and the class declaration. Consider removing it to keep formatting consistent with the other iOS test fixtures in this folder.
| { | ||
| [TestFixture(Category = "Device")] | ||
| [Category("iOS")] | ||
|
|
There was a problem hiding this comment.
There’s an extra blank line between the attribute block and the class declaration. Consider removing it to keep formatting consistent with the other iOS test fixtures.
List of changes
This pull request adds the
[Category("iOS")]attribute to all iOS integration test classes. This change standardizes test categorization, making it easier to run or filter iOS-specific tests in the test suite.Test Categorization Improvements:
[Category("iOS")]attribute to all iOS integration test classes, including those inDeviceandSessionsubfolders, to ensure consistent test filtering and organization. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Types of changes
What types of changes are you proposing/introducing to the .NET client?
Put an
xin the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub