Skip to content

fix: fix type checker errors for pyright #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 10 commits into from
Mar 5, 2026
Merged

fix: fix type checker errors for pyright #1203

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5e0b420
Add `__all__` to specify public API for `appium.webdriver`
ilotoki0804 Mar 1, 2026
8b1ed55
Comment out unimplemented methods in CanExecuteScripts protocol
ilotoki0804 Mar 2, 2026
8228005
Uncomment and add deprecation warnings for unimplemented methods
ilotoki0804 Mar 2, 2026
1e3475b
Update deprecation messages in CanExecuteScripts
ilotoki0804 Mar 2, 2026
024f74f
Restore CanExecuteScripts protocol methods
ilotoki0804 Mar 3, 2026
5ee2faa
Import Remote class from the original source
ilotoki0804 Mar 3, 2026
3354542
Fix formatting
ilotoki0804 Mar 4, 2026
32400fc
Adjust formatting
ilotoki0804 Mar 4, 2026
35f3e0d
Adjust formatting
ilotoki0804 Mar 4, 2026
1949373
Add explicit `__all__` and remove lint exceptions
ilotoki0804 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions appium/webdriver/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,7 @@
Appium Python Client: WebDriver module
"""

__all__ = ["Remote", "WebElement"]
Copy link
Copy Markdown
Member

@KazuCocoa KazuCocoa Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks reasonable to me. This fixes mypy --strict also.


from .webdriver import WebDriver as Remote
from .webelement import WebElement
5 changes: 3 additions & 2 deletions appium/webdriver/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

from typing import TYPE_CHECKING, Any, Callable, Dict, List, Optional, Set, Tuple, Type, Union

from selenium import webdriver
from selenium.common.exceptions import (
InvalidArgumentException,
SessionNotCreatedException,
Expand All @@ -23,6 +22,8 @@
)
from selenium.webdriver.remote.command import Command as RemoteCommand
from selenium.webdriver.remote.remote_connection import RemoteConnection
# `selenium.webdriver.Remote` could be used instead, but Pyright wouldn't locate the class properly.
from selenium.webdriver.remote.webdriver import WebDriver as Remote
from typing_extensions import Self

from appium.common.logger import logger
Expand Down Expand Up @@ -208,7 +209,7 @@ def _get_remote_connection_and_client_config(


class WebDriver(
webdriver.Remote,
Remote,
ActionHelpers,
Activities,
Applications,
Expand Down
Loading