Add experimental support for externalizing graphs to a separate artifact - #77
Open
jakesabathia2 wants to merge 1 commit into
Open
jakesabathia2 wants to merge 1 commit into
jakesabathia2 wants to merge 1 commit into
Conversation
jakesabathia2
marked this pull request as draft
September 1, 2026 23:26
jakesabathia2
force-pushed
the
dev/henry/externalize-graphs-to-artifact
branch
7 times, most recently
from
September 7, 2026 07:12
cebe348 to
9cfa1ec
Compare
jakesabathia2
marked this pull request as ready for review
September 7, 2026 07:12
jakesabathia2
force-pushed
the
dev/henry/externalize-graphs-to-artifact
branch
from
September 7, 2026 07:36
9cfa1ec to
8ac4567
Compare
jakesabathia2
force-pushed
the
dev/henry/externalize-graphs-to-artifact
branch
from
September 9, 2026 23:09
2f13e02 to
80241db
Compare
YifanShenSZ
approved these changes
Sep 9, 2026
cymbalrush
approved these changes
Sep 10, 2026
jakesabathia2
force-pushed
the
dev/henry/externalize-graphs-to-artifact
branch
3 times, most recently
from
September 10, 2026 16:44
c178308 to
5ddbd55
Compare
jakesabathia2
force-pushed
the
dev/henry/externalize-graphs-to-artifact
branch
from
September 11, 2026 22:09
5ddbd55 to
42fbd03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TorchConverterSPI hooks that act on the ops a namednn.Moduleclasscontributed, identified by
nn_module_stackattribution once the graph body is built:_set_delegate_id(class_name, target)coreai.isolated_group<target>graph_set_externalize_group(class_name, namespace, *, externalize=True)coreai.graph(markedexternalize, insidenamespace) and replaces them with acoreai.invoke_set_externalize_name_map(mapping)externalizeAPIs - however, the solution become super tedious and need tons of model reauthorizing at the source torch model level - hence I decided to introduce this new approach 😄 Need more discussion to put this into production.