Conversation
ATen represents the default pooling stride as an empty list. Exported nodes retain that list whenever a later argument is non-default, but the lowerings only treated an absent or None stride as the default and subsequently failed on the empty value. Resolve absent, None, and empty strides to kernel_size for avg_pool2d, avg_pool3d, and max_pool2d_with_indices. Add end-to-end coverage for each affected lowering.
jakesabathia2
requested review from
TobyRoseman and
gokulkrishna98
and removed request for
gokulkrishna98
September 9, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATen represents the default pooling stride as an empty list. Exported nodes keep that value when a later argument is non-default, but the lowerings only handled absent or
Nonestrides and failed on the empty list.This resolves all three default forms to
kernel_sizeforavg_pool2d,avg_pool3d, andmax_pool2d_with_indices. End-to-end tests cover each affected path.Tested with
pytest -q tests/ops/test_ops.py::test_avg_pool2d tests/ops/test_ops.py::test_avg_pool3d tests/ops/test_ops.py::test_maxpool2d...