feat: add Browser And Visual Testing Provider domain + adapter layer (082)#87
Merged
Merged
Conversation
…(082) Introduce the domain model and adapter layer for browser capability providers communicating over the S10 protocol via JSON stdio. The browser provider is an external binary — Boundline does not embed Playwright or any browser automation library. Domain types (src/domain/browser_provider.rs): - StepStatus (7 variants), FindingKind (12 variants), FindingSeverity - ArtifactKind, RetentionClass, ArtifactReference (SHA-256 hashed) - BrowserFinding with optional RetryabilityHint - RetryabilityLevel, RetryabilityCategory, StepTiming - LocatorType, LocatorState, ReadinessLocator - BrowserAction (Navigate/Click/Type/Wait/Screenshot) - BrowserValidationStep, DomInspectionConfig, ValidationTimeouts - BrowserEvidencePacket with full contract schema Adapter layer: - BrowserProviderRuntime: subprocess spawn, startup handshake, JSON request/response dispatch over stdio, stderr capture - BrowserArtifactStore: session-scoped artifact directories, SHA-256 content hashing, per-kind size limits (50MB screenshots, 10MB logs), retention classes (required/diagnostic/verbose/ephemeral) Integration: - BrowserProviderConfig in capability_provider.rs with protocol line - BrowserValidationCompleted trace event type in observability.rs - CLI APIs: run_validate_browser(), inspect_browser_run() (clap wire-up deferred to avoid 30+ match arm changes) - Session scoping via .boundline/sessions/<id>/browser/<run_id>/ (sidecar pattern — no ActiveSessionRecord extension) Roadmap: seed converted to feat-browser-and-visual-testing-provider.md, original removed per move-on-conversion semantics. Version bump: 0.81.0 → 0.82.0 (feature increment). Tests: 1349 passing (0 failures). Coverage: domain types 97.7-100%.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
robertotru
force-pushed
the
082-browser-visual-testing-provider
branch
from
June 24, 2026 11:09
9ee1a17 to
222988c
Compare
robertotru
force-pushed
the
082-browser-visual-testing-provider
branch
from
June 24, 2026 11:45
222988c to
56fbb40
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First delivery slice of Browser And Visual Testing Provider (spec 082). Adds the full domain model, adapter runtime, artifact store, and programmatic CLI APIs to enable browser validation as a provider capability over Boundline's existing S10 protocol. The browser provider is an external binary — Boundline does not embed Playwright or any browser automation library.
What's Included
BrowserProviderConfigstruct +browser-provider-v1protocol lineBrowserValidationCompletedevent typeinspect_browser.rs(~175 lines)run_validate_browser(),inspect_browser_run()Design Decisions
.boundline/sessions/<id>/browser/<run_id>/directories, not embedded inActiveSessionRecord— avoids 22+ compilation breakages (consistent with SessionEconomicsState precedent from spec 081)RequiredEvidence,Diagnostic,Verbose,Ephemeralper specWhat's NOT in this PR
boundline-browser-provideris a separate projectQuality Gates
cargo fmt— cleancargo clippy --workspace --all-targets --all-features -- -D warnings— cleanCoverage Note
Adapter and CLI files (
browser_provider_runtime.rs,browser_artifact_store.rs,validate_browser.rs,inspect_browser.rs) are at 0% — these are thin I/O boundaries that delegate to the fully-tested domain layer. Integration tests require the external mock provider binary.References