MRPHS-3897: Rebasing/Upgrading libretto

[avnish30jn]

Problem

Some new fixes have been added to apcera libretto, which need to be merged with apporbit/libretto.

Solution

Rebased apcera/libretto with apporbit/libretto.

Unit-Testing

Aws Testing

[root@my_machine test]# ./awsclient
1. CreateVM
2. DeleteVM
3. ShutDownVM
4. StartVM
Select one or sequence of method(s) to test:
Ex. 1 <Enter> for CreateVM or 1 2 3 <Enter> for CreateVM followed by Delete and ShutDown VM

Your option: 1
Testing CreateVM...
VM created and is powered on
{"IPs":["13.250.13.138"],"Id":"i-0a953a91092706408"}
Sleeping for 10 seconds
[root@my_machine test]#

[root@my_machine test]# ./awsclient
1. CreateVM
2. DeleteVM
3. ShutDownVM
4. StartVM
Select one or sequence of method(s) to test:
Ex. 1 <Enter> for CreateVM or 1 2 3 <Enter> for CreateVM followed by Delete and ShutDown VM

Your option: 3
Testing ShutDownVM...
VM shutdown successful
Sleeping for 10 seconds


[root@my_machine test]# ./awsclient
1. CreateVM
2. DeleteVM
3. ShutDownVM
4. StartVM
Select one or sequence of method(s) to test:
Ex. 1 <Enter> for CreateVM or 1 2 3 <Enter> for CreateVM followed by Delete and ShutDown VM

Your option: 4
Testing StartVM...VM started successfully
Sleeping for 10 seconds
[root@my_machine test]#


[root@my_machine test]# ./awsclient
1. CreateVM
2. DeleteVM
3. ShutDownVM
4. StartVM
Select one or sequence of method(s) to test:
Ex. 1 <Enter> for CreateVM or 1 2 3 <Enter> for CreateVM followed by Delete and ShutDown VM

Your option: 2
Testing DeleteVM...
VM deleted successfully
Sleeping for 10 seconds
[root@my_machine test]#


Static ip assignment


[root@my_machine example]# go run c3ntry_client.go
Sending request:
action:"create_vms" args:"{\"Insecure\":true,\"cloud_type\":\"vsphere\",\"type\":\"PUBLIC\",\"Host\":\"vcenter.gsintlab.com\",\"Username\":\"admin@vsphere.local\",\"Password\":\"passwd\",\"Datacenter\":\"C3 DataCenter\",\"Destination\":{\"DestinationName\":\"C3 Cluster-1\",\"DestinationType\":\"cluster\",\"HostSystem\":\"\"},\"Datastores\":[],\"cluster_name\":\"Cluster1\",\"network\":{\"networks\":[{\"name\":\"VM Private\"}]},\"skip_ip_wait\":true,\"simple_name\":true,\"custom_suffix\":\"20171229054319\",\"cluster\":[{\"gid\":0,\"name\":\"tier1-vm1\",\"count\":1,\"flavor\":\"custom\",\"resources\":{\"cpu\":2,\"memory\":4096,\"fixed_disks\":[[{\"\":\"Hard disk 1\",\"Size\":100,\"DiskName\":\"[datastore2-ESXi13-2TB] visor_template_2.1/visor_template_2.1.vmdk\"}]]},\"image\":{\"Template\":\"visor_template_2.1\",\"SkipExisting\":2},\"volumes\":[[{\"size\":\"10\",\"Controller\":\"scsi\",\"provisioning\":\"thin\"}]],\"Networks\":[{\"ip_address\":\"10.10.24.231\",\"default_gateway\":\"10.10.24.100\",\"subnet_mask\":\"255.255.255.0\",\"dns_server\":\"10.10.24.50\"}]}]}" id:"cluster:1:vm:1:create"

2017/12/29 02:38:05 Received Response:
result:"{\"0\":{\"1\":{\"vm_name\":\"tier1-vm1-0-20171229054319\",\"instance_id\":\"tier1-vm1-0-20171229054319\",\"vm_id\":\"vm-7240\"},\"gid\":\"0\"}}" id:"cluster:1:vm:1:create" progress:100

2017/12/29 02:38:05 Response String:
{"result":"{\"0\":{\"1\":{\"vm_name\":\"tier1-vm1-0-20171229054319\",\"instance_id\":\"tier1-vm1-0-20171229054319\",\"vm_id\":\"vm-7240\"},\"gid\":\"0\"}}","id":"cluster:1:vm:1:create","progress":100}

2017/12/29 02:38:05 Breaking..
[root@my_machine example]#

Deployed vm apps on starling vcenter with various configurations. The app was deployed successfully. Tried various operations on the app. The operations were completed successfully. Logs are attached below:

c3ntry1.txt
visor.txt

[pankajtandon12]

Please update the testing section of PR template.

Recommended Testing:

• InfraVM and vsphere-c3-cluster creation for various config types
• single/multi-vm
• DRS enabled/disabled
• DHCP/static-ip
• VM template/visor workflows
• AWS/GCP cloud-support basic testing

[pankajtandon12]

Is go1.9+ mandatory or recommended?
i.e. Ensure no build failure in go 1.7 enviornment

[avnish30jn]

go1.9+ is recommended and build is not failing with go 1.7.

[avnish30jn]

Testing done for the below:

InfraVM
single/multi-vm
DRS enabled/disabled
DHCP/static-ip
VM template/visor workflows
AWS cloud-support basic testing

Tried vsphere-c3-cluster creation for various with create_vms and cluster_configure manually as two separate steps as controller does not support c3-vmware cluster creation now(with the old ui as well).
Not done for Gcp as gcp credentials are not there. Also we are not using GCP anywhere as of now, this can be tested once the gcp changes are being used by c3ntry.

[pankajtandon12]

LGTM.
Assuming this is auto-rebase from apcera/libretto without any code-conflict.
Please open a jira ticket to do "session logout" before cancelling it for all newly added instances, as recommended by updated libretto.

[avnish30jn]

Created jira ticket MRPHS-4436 to track this.