Skip to content

Fix missing metadata on successful requests#60

Merged
unflxw merged 1 commit into
mainfrom
fix-missing-metadata-success
Apr 27, 2026
Merged

Fix missing metadata on successful requests#60
unflxw merged 1 commit into
mainfrom
fix-missing-metadata-success

Conversation

@unflxw
Copy link
Copy Markdown
Contributor

@unflxw unflxw commented Apr 27, 2026

Fixes #59.

Fix an issue where metadata is not set on successful requests, causing the extension to drop the traces for those requests.

Fix an issue where metadata is not set on successful requests,
causing the extension to drop the traces for those requests.
@unflxw unflxw requested review from lipskis and tombruijn April 27, 2026 08:29
@unflxw unflxw self-assigned this Apr 27, 2026
@unflxw unflxw added the bug Confirmed and unconfirmed bugs reported by us and customers. label Apr 27, 2026
@unflxw
Copy link
Copy Markdown
Contributor Author

unflxw commented Apr 27, 2026

@bkma Feel free to test the changes against the fix-missing-metadata-success branch, though note that it is the same as your suggested fix.

@unflxw unflxw merged commit 2b7791f into main Apr 27, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Confirmed and unconfirmed bugs reported by us and customers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Appsignal.Plug success path closes span before setting name/attributes, causing traces to be dropped

2 participants