Skip to content

Rust edition 2024 (12 of 14 crates) - #14

Merged
principalwater merged 1 commit into
mainfrom
rust-edition-2024
Aug 21, 2026
Merged

principalwater merged 1 commit into
mainfrom
rust-edition-2024

Conversation

@principalwater

Copy link
Copy Markdown
Collaborator

Moves the workspace to edition 2024. 492 tests green, identical to before. Clippy clean under -D warnings on stable 1.98.0.

Two crates stay on 2021 on purpose: artesian-process-agent and artesian-bench set process env vars, which edition 2024 makes unsafe because it is not thread safe. The workspace sets unsafe_code = "forbid" deliberately, and I would rather leave two crates a version behind than weaken that invariant for a test.

The real fix is to make those env reads injectable — the production path calls std::env::var directly, so the test currently has no other way to drive it. That is a separate change from an edition bump, so I left it out.

artesian-process-agent and artesian-bench stay on 2021. Edition 2024 makes
std::env::set_var unsafe because it is not thread safe, and the workspace sets
unsafe_code = forbid deliberately. Wrapping the calls would punch a hole in
that invariant to satisfy a test, so the two crates keep the old edition and
carry a note.

The real fix is to make those env reads injectable instead of global; the
production path reads std::env::var directly, so the test has no other way in.
That is a separate change, not an edition bump.

492 tests green, unchanged.

@elementary-flow-bot elementary-flow-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed: auto-approved by bot.

@principalwater
principalwater merged commit 14e4f2d into main Aug 21, 2026
1 check passed
@principalwater
principalwater deleted the rust-edition-2024 branch August 21, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants