Repository navigation
Rust edition 2024 (12 of 14 crates) - #14
Merged
Merged
Conversation
artesian-process-agent and artesian-bench stay on 2021. Edition 2024 makes std::env::set_var unsafe because it is not thread safe, and the workspace sets unsafe_code = forbid deliberately. Wrapping the calls would punch a hole in that invariant to satisfy a test, so the two crates keep the old edition and carry a note. The real fix is to make those env reads injectable instead of global; the production path reads std::env::var directly, so the test has no other way in. That is a separate change, not an edition bump. 492 tests green, unchanged.
elementary-flow-bot
approved these changes
Aug 21, 2026
elementary-flow-bot
left a comment
Collaborator
There was a problem hiding this comment.
CI passed: auto-approved by bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the workspace to edition 2024. 492 tests green, identical to before. Clippy clean under
-D warningson stable 1.98.0.Two crates stay on 2021 on purpose:
artesian-process-agentandartesian-benchset process env vars, which edition 2024 makesunsafebecause it is not thread safe. The workspace setsunsafe_code = "forbid"deliberately, and I would rather leave two crates a version behind than weaken that invariant for a test.The real fix is to make those env reads injectable — the production path calls
std::env::vardirectly, so the test currently has no other way to drive it. That is a separate change from an edition bump, so I left it out.