Quality improvement - #9
Conversation
chore: update README and CLI to enhance AgentMesh watcher functionali…
…cy checks in the pipeline
…, enhance file handling in adapters, and improve privacy checks in the pipeline
Extract CLI inspection and hook management into focused modules, move core doctor reporting behind pipeline/doctor.rs, and isolate watcher service registration. Split adapter hook handling and SDK frontmatter helpers while preserving the existing public APIs and behavior.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b6a807d. Configure here.
|
|
||
| const MAX_ENTITY_TREE_DEPTH: usize = 32; | ||
| const MAX_ENTITY_FILE_COUNT: usize = 1024; | ||
| const MAX_ENTITY_TOTAL_BYTES: u64 = 64 * 1024 * 1024; |
There was a problem hiding this comment.
Entity limit constants duplicated across two crates
Low Severity
MAX_ENTITY_TREE_DEPTH, MAX_ENTITY_FILE_COUNT, and MAX_ENTITY_TOTAL_BYTES are identically defined in both agentmesh-adapter-sdk-rust and agentmesh-core. Both crates depend on agentmesh-protocol, which already hosts shared constants like MAX_FRAME_BYTES. These limits enforce the same conceptual constraint on entity trees and could silently drift if only one copy is updated.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b6a807d. Configure here.


Note
Medium Risk
Changes sync/import and doctor behavior (symlinks rejected, size limits) and adapter JSON-RPC framing; mostly defensive but can alter repos that relied on symlinks or very large adapter messages.
Overview
Releases 0.1.2 and ignores
.ai/andagentmesh.lockin git.Hardens filesystem and adapter I/O: entity trees reject symlinks and enforce depth/file-count/size caps; imports use
symlink_metadataand skip symlinked paths with explicit reasons. JSON-RPC stdio now caps frames at 64 MiB before allocating bodies. Shared SDK gainscollect_entity_files,is_regular_file/dir, and frontmatter moved to its own module; Claude/Codex hook install/remove live in dedicatedhooksmodules.Doctor logic moves to
pipeline/doctor.rsand adds lockfile privacy heuristics (sensitive ids, paths, override keys) surfaced inDoctorHealth.lockfile_privacy_warnings.jsonschemadrops default features (smaller lockfile). Watcher service registration splits intoservice.rs. CI runsinstallers/test-install.sh.Reviewed by Cursor Bugbot for commit efbb5a3. Bugbot is set up for automated code reviews on this repo. Configure here.