Skip to content

Quality improvement - #9

Merged
ar4ntic merged 8 commits into
devfrom
quality-improvement
Jun 1, 2026
Merged

ar4ntic merged 8 commits into
devfrom
quality-improvement

Conversation

@ar4ntic

@ar4ntic ar4ntic commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Changes sync/import and doctor behavior (symlinks rejected, size limits) and adapter JSON-RPC framing; mostly defensive but can alter repos that relied on symlinks or very large adapter messages.

Overview
Releases 0.1.2 and ignores .ai/ and agentmesh.lock in git.

Hardens filesystem and adapter I/O: entity trees reject symlinks and enforce depth/file-count/size caps; imports use symlink_metadata and skip symlinked paths with explicit reasons. JSON-RPC stdio now caps frames at 64 MiB before allocating bodies. Shared SDK gains collect_entity_files, is_regular_file/dir, and frontmatter moved to its own module; Claude/Codex hook install/remove live in dedicated hooks modules.

Doctor logic moves to pipeline/doctor.rs and adds lockfile privacy heuristics (sensitive ids, paths, override keys) surfaced in DoctorHealth.lockfile_privacy_warnings. jsonschema drops default features (smaller lockfile). Watcher service registration splits into service.rs. CI runs installers/test-install.sh.

Reviewed by Cursor Bugbot for commit efbb5a3. Bugbot is set up for automated code reviews on this repo. Configure here.

ar4ntic added 6 commits May 28, 2026 17:17
chore: update README and CLI to enhance AgentMesh watcher functionali…
…, enhance file handling in adapters, and improve privacy checks in the pipeline
Extract CLI inspection and hook management into focused modules, move core doctor reporting behind pipeline/doctor.rs, and isolate watcher service registration. Split adapter hook handling and SDK frontmatter helpers while preserving the existing public APIs and behavior.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b6a807d. Configure here.

Comment thread crates/agentmesh-core/src/pipeline.rs

const MAX_ENTITY_TREE_DEPTH: usize = 32;
const MAX_ENTITY_FILE_COUNT: usize = 1024;
const MAX_ENTITY_TOTAL_BYTES: u64 = 64 * 1024 * 1024;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entity limit constants duplicated across two crates

Low Severity

MAX_ENTITY_TREE_DEPTH, MAX_ENTITY_FILE_COUNT, and MAX_ENTITY_TOTAL_BYTES are identically defined in both agentmesh-adapter-sdk-rust and agentmesh-core. Both crates depend on agentmesh-protocol, which already hosts shared constants like MAX_FRAME_BYTES. These limits enforce the same conceptual constraint on entity trees and could silently drift if only one copy is updated.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b6a807d. Configure here.

@ar4ntic
ar4ntic merged commit 5fb06d3 into dev Jun 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant