fix: GitHub webhook route to API router - #84
Open
ar4ntic wants to merge 3 commits into
Open
Conversation
- Integrated GitHub webhook routes into the API router. - Updated test suite to verify the correct mount order for GitHub webhook handling.
…ed-before-signature-validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Routing-order change only; GitHub webhook behavior is unchanged aside from fixing incorrect auth rejection.
Overview
Fixes inbound GitHub deliveries to
POST /api/webhooks/github/:integrationIdbeing blocked by session auth on the outbound webhooks admin API before the GitHub handler could validateX-Hub-Signature-256.createApiRouternow registers/webhooks/githubwith the core CE routes, before the authenticated/webhooksmount (which appliesauthMiddlewareto all subpaths). The duplicate mount at the bottom of the router is removed.The v1.2.2 changelog documents the fix. A route test asserts that with this order, requests hit the GitHub handler (
401Missing signature) instead ofUNAUTHORIZED/ Authentication required.Reviewed by Cursor Bugbot for commit 73b8745. Bugbot is set up for automated code reviews on this repo. Configure here.