Skip to content

fix: GitHub webhook route to API router - #84

Open
ar4ntic wants to merge 3 commits into
devfrom
83-github-webhook-endpoint-returns-unauthorized-before-signature-validation
Open

fix: GitHub webhook route to API router#84
ar4ntic wants to merge 3 commits into
devfrom
83-github-webhook-endpoint-returns-unauthorized-before-signature-validation

Conversation

@ar4ntic

@ar4ntic ar4ntic commented Sep 8, 2026

Copy link
Copy Markdown
Contributor
  • Integrated GitHub webhook routes into the API router.
  • Updated test suite to verify the correct mount order for GitHub webhook handling.

Note

Low Risk
Routing-order change only; GitHub webhook behavior is unchanged aside from fixing incorrect auth rejection.

Overview
Fixes inbound GitHub deliveries to POST /api/webhooks/github/:integrationId being blocked by session auth on the outbound webhooks admin API before the GitHub handler could validate X-Hub-Signature-256.

createApiRouter now registers /webhooks/github with the core CE routes, before the authenticated /webhooks mount (which applies authMiddleware to all subpaths). The duplicate mount at the bottom of the router is removed.

The v1.2.2 changelog documents the fix. A route test asserts that with this order, requests hit the GitHub handler (401 Missing signature) instead of UNAUTHORIZED / Authentication required.

Reviewed by Cursor Bugbot for commit 73b8745. Bugbot is set up for automated code reviews on this repo. Configure here.

- Integrated GitHub webhook routes into the API router.
- Updated test suite to verify the correct mount order for GitHub webhook handling.
@ar4ntic ar4ntic changed the title feat: add GitHub webhook route to API router fix: add GitHub webhook route to API router Sep 8, 2026
@ar4ntic ar4ntic changed the title fix: add GitHub webhook route to API router fix: GitHub webhook route to API router Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant