Linux compatibility#4
Closed
LewdDevelopment wants to merge 8 commits into
Closed
Conversation
A bit out of scope, fill_drive unnecessarily read images to memory, which severely hurts performance and is potentially dangerous with other options like running on startup
Owner
|
added in 10a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Linux compatibility for at least most major features. Much of this is adapted or copied from PetitTournesol#41, and this code has not been tested on Windows.
Major changes include using pathlib to manage paths platform agnostically, separating OS specific code into their own files, and replacing all
os.startfilecalls withsubprocessfunctions.