Open
Conversation
Olexbaiko
reviewed
Feb 24, 2025
Olexbaiko
reviewed
Feb 24, 2025
|
|
||
| // CSVImporterHandler handles CSV files | ||
| func CSVImporterHandler(w http.ResponseWriter, r *http.Request, session *Session) { | ||
| if err := r.ParseMultipartForm(32 << 20); err != nil { |
Collaborator
There was a problem hiding this comment.
pls add comments/description why to use 32 << 20 - sounds like magic
Collaborator
Author
There was a problem hiding this comment.
It's 32 Mb. I just use the same approach I see everywhere in uadmin...
Olexbaiko
reviewed
Feb 24, 2025
Olexbaiko
reviewed
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides the requested feature for the model in the request.
Further enhancement of this feature in this CMS requires some clarification, a plenty of efforts.
Currently, this handler able to hand only one use case (there is a hardcoded field name for foreign key, it's a significant restriction). To make it general, we have to understand how a foreign key with multiple fields should be stored in a CSV file and described in/as a model to have a way to find it in the DB during handling.