fix: update message and rename conversation triggers#2439
fix: update message and rename conversation triggers#2439mustafa-sayyed wants to merge 5 commits intoarc53:mainfrom
Conversation
|
@mustafa-sayyed is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey, @dartpain @ManishMadan2882 |
There was a problem hiding this comment.
Pull request overview
This PR addresses #2369 by preventing “Update”/rename actions from triggering when the edited value is empty or unchanged, improving UX and avoiding unnecessary submissions.
Changes:
- Adds guards to prevent saving a conversation name if it’s empty or unchanged.
- Prevents edited message submission when the edit input is empty or unchanged.
- Disables the “Update” button (and adjusts styling) when edits are invalid.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/conversation/ConversationTile.tsx | Adds an unchanged/empty guard before calling onSave for conversation renames. |
| frontend/src/conversation/ConversationBubble.tsx | Adds unchanged/empty guards for message edits and disables the “Update” button accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ManishMadan2882
left a comment
There was a problem hiding this comment.
@mustafa-sayyed Thanks for the fix.
one blocking concern:
- Build is failing
npm run build: fix is minimal - use the same null-coalesce pattern already used elsewhere in this file (line 209 already does setEditInputBox(message ?? ''))
> frontend@0.0.0 build
> tsc && vite build
src/conversation/ConversationBubble.tsx:135:57 - error TS18048: 'message' is possibly 'undefined'.
135 if (!editInputBox.trim() || editInputBox.trim() === message.trim()) return;
~~~~~~~
src/conversation/ConversationBubble.tsx:248:77 - error TS18048: 'message' is possibly 'undefined'.
248 disabled={!editInputBox.trim() || editInputBox.trim() === message.trim()}
~~~~~~~
Found 2 errors in the same file, starting at: src/conversation/ConversationBubble.tsx:135
|
@ManishMadan2882 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
- Coverage 91.34% 91.16% -0.19%
==========================================
Files 248 255 +7
Lines 20709 21675 +966
==========================================
+ Hits 18916 19759 +843
- Misses 1793 1916 +123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ManishMadan2882
left a comment
There was a problem hiding this comment.
all comments resolved, thanks!
|
Hii @ManishMadan2882 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This PR fixes: #2369
Tested the changes, Videos:
Screen.Recording.2026-04-29.124843.mp4
Screen.Recording.2026-04-29.124934.mp4