Skip to content

test(e2e): multi-viewport journey matrix with diag + screenshot dumps#307

Open
jbdevprimary wants to merge 1 commit into
mainfrom
feat/e2e-multi-viewport-journey
Open

test(e2e): multi-viewport journey matrix with diag + screenshot dumps#307
jbdevprimary wants to merge 1 commit into
mainfrom
feat/e2e-multi-viewport-journey

Conversation

@jbdevprimary
Copy link
Copy Markdown
Collaborator

Summary

  • New Playwright spec `e2e/journey-matrix.spec.ts` (tagged `@nightly`) walks the full player journey across ALL three viewport projects (desktop-chromium, mobile-portrait, tablet-landscape)
  • At every stage (MOUNT → TITLE → BEFORE_PLAY → AFTER_PLAY → DRIVING): attaches PNG screenshot + full `window.__mm.diag()` JSON to the Playwright report, and logs a summary line to stdout
  • Surfaces `pageerror` + `console.error` events into the test log — no more mystery failures buried in the bundle

This addresses the direct feedback: "none of this should be a MYSTERY, that's what BROWSER testing should actually be exposing, using multiple viewports, doing diagnostic dumps during e2e".

Complements the vitest-side `PlayerJourney.browser.test.tsx` (local Chrome harness) by running against the real production preview server with actual Playwright device profiles.

Test plan

  • CI nightly runs produce 3 × 5 = 15 PNG + 15 JSON artifacts per run (one set per viewport × stage)
  • Distance advance assertion fires after drop-in completes (not during the drop animation)
  • `pageerror` / `console.error` events appear in the Playwright log when they occur
  • Mobile portrait + tablet landscape viewports reach the DRIVING stage (no layout blockers)

🤖 Generated with Claude Code

… artifacts

Walks the full player journey (MOUNT → TITLE → BEFORE_PLAY → AFTER_PLAY →
DRIVING) across all three Playwright projects (desktop-chromium,
mobile-portrait, tablet-landscape). At every stage:

- PNG screenshot attached to the Playwright report so the HTML viewer
  (gh actions artifact) shows the full journey per viewport
- Full window.__mm.diag() JSON attached as artifact so CI runs contain
  a complete state transcript
- Summary line logged to stdout for quick scanning

Also surfaces pageerror + console.error events to the test log so
runtime failures stop being mysteries hidden inside the bundle.

Tagged @nightly so it stays out of the fast smoke gate.
Copilot AI review requested due to automatic review settings April 24, 2026 15:53
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@jbdevprimary has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 31 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 31 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e493b210-3729-484e-82e0-dc20b8dd5d00

📥 Commits

Reviewing files that changed from the base of the PR and between c56aac4 and 32d10b9.

📒 Files selected for processing (1)
  • e2e/journey-matrix.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/e2e-multi-viewport-journey

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants