fix: pin eigency==3.4.0.7 to fix segfaults from ABI mismatch#44
Merged
fix: pin eigency==3.4.0.7 to fix segfaults from ABI mismatch#44
Conversation
The build-time and runtime eigency versions must match because eigency_cpp.h (included at compile time) hardcodes Cython API symbol names that must be present in the runtime conversions.so. eigency 3.4.0.7 (PR #73) renamed all API symbols from per-type names (e.g. ndarray_complex_double_F) to fused-type names (e.g. __pyx_fuse_14ndarray_F). A version mismatch between build-time and runtime causes segfaults due to missing symbols. Previously, [build-system] requires used >=3.4.0.0 which resolved to 3.4.0.7 in the isolated PEP 517 build environment, while uv.lock pinned runtime to 3.4.0.4, causing the mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All tests crash with segfaults (exit code 139 on Linux/macOS, exit code 1 on Windows) across all Python versions and platforms.
Root Cause
[build-system] requireshadeigency>=3.4.0.0, which resolved to 3.4.0.7 in the isolated PEP 517 build environment, whileuv.lockpinned the runtime dependency to 3.4.0.4.eigency 3.4.0.7 (PR #73) renamed all Cython API symbols from per-type names (e.g.
ndarray_complex_double_F) to fused-type names (e.g.__pyx_fuse_14ndarray_F). The compiled extension (SecondOrderNLTMM.so) includeseigency_cpp.hat build time, which hardcodes these symbol names. At runtime, the extension calls into eigency'sconversions.so— if the symbol names don't match, it segfaults.Fix
Pin
eigency==3.4.0.7in both[build-system] requiresand[project] dependenciesto ensure the build-time and runtime versions always match.