feature(systemd): added the ability to start a service#20
Merged
pzindyaev merged 1 commit intoarenadata:mainfrom Nov 10, 2025
Merged
feature(systemd): added the ability to start a service#20pzindyaev merged 1 commit intoarenadata:mainfrom
pzindyaev merged 1 commit intoarenadata:mainfrom
Conversation
74eae1c to
44b0243
Compare
Asmoday
reviewed
Nov 7, 2025
cmd/ad-runtime-utils/app.go
Outdated
| fs.BoolVar(listAll, "l", false, "shorthand for --list") | ||
| printCACerts := fs.Bool("print-cacerts", false, "When used with --runtime=java, prints the cacerts path and exits") | ||
| start := fs.Bool("start", false, "Start the service. Use with simple/exec services") | ||
| supervise := fs.Bool("supervise", false, "Supervise the service. Use with norify services") |
internal/config/config.go
Outdated
| continue | ||
| } | ||
| // Split on the first '=' to get the key-value pair | ||
| splitSubstrings := 2 |
Collaborator
There was a problem hiding this comment.
We usually encounter xxx-env.sh with a script, maybe add support too (just source)?
Collaborator
Author
There was a problem hiding this comment.
Added support for sourcing the env file before running the executable
It's a bit hacky, but I didn't find any other reliable way to support script sourcing in go
e4f9b5d to
a625946
Compare
a625946 to
0f4fc8f
Compare
Asmoday
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.