Conversation
giggsoff
force-pushed
the
fix-pip-show-parsing
branch
2 times, most recently
from
ab4f6e5 to
6631616
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
giggsoff
force-pushed
the
fix-pip-show-parsing
branch
from
6631616 to
50505f6
Compare
src/adcm_client/packer/types.py
Outdated
| elif in_files_section and line.startswith(" "): | ||
| resulting_lines.append(line) | ||
| else: | ||
| in_files_section = False |
There was a problem hiding this comment.
I think this should be a separate function like "sanitize input" with doctests/tests for the function itself
Now it's very complicated to read and understand what's the expected output
With separate function we'll see if it can be reworked somehow based on input and output presented in tests
There was a problem hiding this comment.
Good point, thank you! Let me split it and prepare unit test.
There was a problem hiding this comment.
Modified.
Few comments:
- I am not sure that unit tests running in CI
- I can see strange error
mkdir: can't create directory '/tmp/build_with_requirements_83tq3m3l/community/pmod': No such file or directory\ncp:...': No such file or directory\nchown: /tmp/build_with_requirements_83tq3m3l/community/pmod: No such file or directory\n". Looks like it come during creation of pmod directory, which looks not related with PR changes.
There was a problem hiding this comment.
I was able to avoid the problem with mkdir: can't create directory using workspace derived from the current tests directory instead of /tmp, this is still weird but seems environment related and not PR related.
pip show returns not valid yaml, i.e. for pip show ipython we can see "Summary: IPython: Productive Interactive Computing" so we should extract only required fields (Location, Files and children of Files) Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
giggsoff
force-pushed
the
fix-pip-show-parsing
branch
2 times, most recently
from
1482d43 to
ebbe73a
Compare
Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
Signed-off-by: Petr <giggsoff@gmail.com>
giggsoff
force-pushed
the
fix-pip-show-parsing
branch
2 times, most recently
from
0d157e4 to
59e9f79
Compare
Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
giggsoff
force-pushed
the
fix-pip-show-parsing
branch
from
59e9f79 to
15e0a97
Compare
|
2 participants
pip showreturns not valid yaml, i.e. forpip show ipythonwe can seeSummary: IPython: Productive Interactive Computing. So we should extract only required fields (Location, Files and children of Files)