Changes prepared_image option for python_mod

[Maunty]

In case when we have long python_mod_req spec preprocess it whould be good to
have prepared image with all required staff intalled. Then bundle python
modules intallation step will become a copy procedure that will be much faster.
Feature is turned on by adding -i flag to adcm_sdk_pack launch.
Was refactored mechanism naming of modified image. Without -i option modified
image is always build. With it - packer try to find prepared image that
corespond to current hash of base image name and requirements.yaml, if image is
not found then it is prepared and not removed.

Example:

     - type: python_mod_req
       requirements: requirements.yml
       image: arenadata/adcm:2020013015
       target_dir: ansible

[Maunty]

@vgorkavenko To be honest i dont like this implementation because we need 2 actions to bring this feature work.
I think that it will be better to change algorithm to something like like that:

• Get base image version
• Get requirements.yaml hash
• Compute some uniq tag for this case.
  In this case this option can be used even on CI because this will be prepared image validation algorithm.
  What do u think?

[vgorkavenko]

@Maunty In this implementation, it seems to me that Flags class is superfluous. If, in your opinion, this is necessary, then you need to give it a more informative name, since "Flags" is too general. Also I think prepare_image option should take image name (and not take that name from spec.yaml). As for algorithm, I doubt that my opinion can somehow help you, since I don't know much about packaging bundles and processes in CI :)

[dgusakov]

Suggested change

	image_name = kwargs.get("image", "arenadata/adcm:latest")
	image_name = kwargs.get("image", "hub.arenadata.io/adcm/adcm:latest")

[Maunty]

@dgusakov I removed this variable. Using a default image instead of defined one will lead to a unpredictable result in long terms.

[dgusakov]

Is there any external description for this "behavior"?
If not consider extending this help

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication