This repository was archived by the owner on Jan 14, 2026. It is now read-only.
Open
Conversation
red1452
added a commit
that referenced
this pull request
Jun 15, 2023
Run script concourse/scripts/upgrade_test_diskquota.sh in Docker to run upgrade test of diskquota. Before starting upgrade test new script build version 1.0.3 (from tag 1.0.3_arenadata2). Check of minor in version of diskquota was removed from diskquota worker process, because we use symlinks from ealier versions (since 2.0) diskquota to the latest version (commit 472eb06).
RekGRpth
reviewed
Jun 27, 2023
Closed
red1452
added a commit
that referenced
this pull request
Oct 3, 2023
Run script concourse/scripts/upgrade_test_diskquota.sh in Docker to run upgrade test of diskquota. Before starting upgrade test new script build version 1.0.3 (from tag 1.0.3_arenadata2). Check of minor in version of diskquota was removed from diskquota worker process, because we use symlinks from ealier versions (since 2.0) diskquota to the latest version (commit 472eb06).
red1452
changed the title
red1452
changed the title
red1452
added a commit
that referenced
this pull request
Oct 3, 2023
Upgrade test runs after regression test. It is need to generate tar-archive with previous
versions of diskquota. Path to archive is set in command to run Docker:
"<PATH_TO_ARCHIVE_WITH_OLD_VERSIONS>".
Before run tests it is needed to run build step:
```
docker run --rm -it -e DISKQUOTA_OS=rhel7 \
-v /tmp/diskquota_artifacts:/home/gpadmin/diskquota_artifacts \
-v <PATH_TO_DISKQUOTA_SRC>:/home/gpadmin/diskquota_src \
-v <PATH_TO_CMAKE_INSTALL_SCRIPT>:/home/gpadmin/bin_cmake/cmake-3.20.0-linux-x86_64.sh \
hub.adsw.io/library/gpdb6_regress:latest diskquota_src/concourse/scripts/entry.sh build
```
Full command to run all tests in Docker:
```
docker run --rm -it --sysctl 'kernel.sem=500 1024000 200 4096' \
-v /tmp/diskquota_artifacts:/home/gpadmin/bin_diskquota \
-v <PATH_TO_DISKQUOTA_SRC>:/home/gpadmin/diskquota_src \
-v <PATH_TO_CMAKE_INSTALL_SCRIPT>:/home/gpadmin/bin_cmake/cmake-3.20.0-linux-x86_64.sh \
-v <PATH_TO_ARCHIVE_WITH_OLD_VERSIONS>:/home/gpadmin/diskquota_old_versions.tar \
hub.adsw.io/library/gpdb6_regress:latest diskquota_src/concourse/scripts/entry.sh test
```
This reverts commit 50ed2e4.
If previous versions of diskquota were added from DISKQUOTA_LAST_RELEASE_PATH do not need to create symlinks from ealier versions (since 2.0) diskquota to the latest version which added at commit 472eb06 New check disable creating symlinks if diskquota was build with -DDISKQUOTA_LAST_RELEASE_PATH and enable creating symlinks if there is not -DDISKQUOTA_LAST_RELEASE_PATH
Information about how to run upgrade tests for diskquota was added to arenadata/README.md.
red1452
added a commit
that referenced
this pull request
Oct 6, 2023
After commit 97f1f9b all DDL files were moved to directory "control/ddl". At upgrade test there is check, which finds diff at DDL files from last release version. Path, where DDL files are found, was not changed, and this check did not work.
After commit 97f1f9b all DDL files were moved to directory "control/ddl". At upgrade test there is check, which finds diff at DDL files from last release version. Path, where DDL files are found, was not changed, and this check did not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade test runs after regression test. It requires to use tar-archive with previous versions of diskquota, which was generated from last release. This archive is generated at
diskquota_artifactsand nameddiskquota-<VERSION>-rhel7_x86_64.tar.gzPath to this archive is set in command to run Docker:<PATH_TO_ARCHIVE_WITH_OLD_VERSIONS>. At this archive all*.sofiles must be atlib/postgresqlpath:Before run tests it is needed to run build step:
Command to run all tests in Docker is not changed:
After releasing new version of diskquota it should to get new archive from diskquota_artifacts and use it at tests for next pull requests.