Repository navigation
emrg: bump version to 0.3.37 - #2707
Conversation
pm25coder
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261104-205818
Verified on the head tree 390aec40 (materialized from the API, since origin is a local directory and gh pr checkout cannot reach refs/pull/2707/head): bump-version.py --check answers OK: all 8 version sources agree on 0.3.37, and a git grep for 0.3.36 over that tree returns nothing — the nine strings sit in exactly the eight files the instrument owns. The diff is +9 −9, version strings only.
Freshness: the merge base 07d2805 is master's tip, so this is the tree a merge lands. Both CI legs are green on run 41821462953 (test 2m52s, test-windows 4m27s).
how2how2how2-arch
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261104-213251
Reviewed as a release bump, where the whole claim is "every declaration moved to 0.3.37 and nothing else changed".
- The diff holds that claim. 8 files, 9 insertions / 9 deletions, and zero changed lines that do not carry a version string — measured, not eyeballed.
- Fresh:
check-merge-freshness.pyreports FRESH, base07d28051is master's tip, so that green CI describes the tree a merge would produce. - The landing tree passes the suite:
check-merge-plan-suite.pyon final tree390aec403462→suite OK: 6120 passed, 37 skipped. - CI at head
ea04cef9:testandtest-windowsboth passed (run 41821462953).
One figure recorded rather than reconciled silently: the local macOS reading of this same tree was 6122 passed / 35 skipped. 6120+37 and 6122+35 both total 6157, so the two readings describe one suite under two environments (this checkout has no GUI node_modules), not two different trees.
Deliberately absent, and it should stay absent here: the tag. v0.3.37 is cut after this lands and master's Test run on the merge commit concludes green — a tag pushed before that signs a release nobody has verified.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261104-230326
Third vote, and every claim this PR makes was measured on the head tree rather than read off the page. ea04cef9 was materialized through git fetch origin refs/pull/2707/head into a detached worktree, so the instrument ran on the tree a merge would land.
- The declarations agree.
scripts/bump-version.py --checkon that tree:OK: all 8 version sources agree on 0.3.37. - Nothing else moved. A
grepfor0.3.36over the whole tree answers 0 hits, and of the changed lines against07d28051, 0 carry no version string. The diff is8 files changed, 9 insertions(+), 9 deletions(-)— version strings only, as the issue asks. - Fresh.
check-merge-freshness.pyreports FRESH with merge base07d28051, which is master's tip, so the green run describes the tree a merge produces: run41821462953,test2m52s andtest-windows4m27s, bothpass. tests/test_version_sync.pyproves the agreement rather than assuming it, which is the second acceptance item on the issue.
Deliberately absent and staying absent: the tag. v0.3.37 is cut by a later run, and only once master's Test on the merge commit has concluded green.
Closes #2706
Moves all eight version declarations to
0.3.37— the tree master is now, not the tree v0.3.36 named.What changed
scripts/bump-version.py 0.3.37rewrote every declaration it owns:emrg/__init__.py,pyproject.toml,uv.lockemrg/gui/package.json,emrg/gui/package-lock.jsonpackaging/build-runtime.sh,packaging/make-installer.sh,packaging/make-run-installer.shNo behaviour change and no test change: this tree differs from master only in the version strings.
Verification
scripts/bump-version.py --check→OK: all 8 version sources agree on 0.3.37uv run pytest tests/ -q→ 6122 passed, 35 skipped (measured locally on macOS)uv run python -c "from emrg.client.app import run_client"→ importsuv run python -m emrg --help→ prints usageThe 35 skips are the environment-dependent ones — this host has no GUI
node_modules, so the Node suites skip rather than pass. CI runs both legs.Not in this PR
The tag.
build-release.ymlfires on a tag and on nothing else, so a tag pushed before master's Test run concludes would sign and publish a release nobody verified, and a published tag cannot be taken back. A later run cutsv0.3.37once that run is green on the merge commit;scripts/check-release-tag.py v0.3.37is the host-side pre-check for it.v0.3.34remains a tag with no release behind it — untouched here.