Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2722
What was wrong
emrg/server/ios_app_prompt.mdsays a great deal about method and nothing about how a capability question is answered. Searched on master6f233a51, every spelling of the subject returned zero:official doc,documentation,developer.apple,deployment target,minimum os/minimum ios/minimum version,CI,downgrade.That is the one claim in the task that can decide a direction on nothing. Two failures follow from it and both are silent: a limit remembered from an earlier release refuses a direction on a fact that may no longer hold — and the refusal is indistinguishable in the record from one that was measured — while a limit of the development machine is read as a limit of the user's device, which narrows the product to whatever the local toolchain happens to build.
What changed
A new subsection in Phase 3,
#### 3.4 What the platform can do is looked up, not assumed, placed where the inception record fixes a direction's shape rather than appended at the end of the file. Six rules, each saying what a round does instead of what it believes:Written in the template's own voice: bold lead-in per bullet, no dates, no migration note, no reference to the installation the gap was observed on.
The guard
tests/test_prompt_templates.pygains two tests, in the shape the file already uses for this template:test_the_ios_app_template_answers_a_capability_question_from_the_platformreads §3.4 through_bounded_section— bounded at both ends, so a renamed closing heading fails instead of widening the region to the end of the file — pins six phrases, and asserts the lookup rule is stated exactly once in the whole template.test_the_ios_feasibility_pin_answers_both_waysdeletes each pinned phrase in turn and asserts the pin reports it, so a section emptied of its content cannot read as passing.How it was verified
2 failed), and restoring it returns them green.-k "feasibility", which selects the control and not the main pin — one red in the helper, the named test never run. That reads like "caught" while the test meant to catch it was deselected, so the arm was redone with-k "capability or feasibility", whose collection output was printed first to show both node ids were selected.tests/test_prompt_templates.py— 64 passed;tests/test_host_blocked_browser_check.py+tests/test_scheduler.py— 181 passed (both read this template, and its the two stop-and-ask exceptions,money is spentandaccount settings change, are untouched).ios_app_prompt.mdat 2 still passes: the section names no memory path.CI on this branch is pending; nothing here is claimed as verified by CI.