Fix build issues and add trainer for 3-style corners#193
Open
louis-hildebrand wants to merge 27 commits into
Open
Fix build issues and add trainer for 3-style corners#193louis-hildebrand wants to merge 27 commits into
louis-hildebrand wants to merge 27 commits into
Conversation
JCenter is no longer available.
Use the same versions as what I got working for the vintage-chroma dependency for convenience.
The dependency com.pavelsikun:vintage-chroma:1.5 is no longer available. As a workaround, make a git submodule from the vintage-chroma repo and add it as a subproject in Gradle.
Add 3-style corners trainer
The category select and locale select dialogs were crashing due to `getDialog().getWindow().requestFeature(Window.FEATURE_NO_TITLE)` being called after content was added to the dialog (according to the error message). Moving this line from `onViewCreated` to `onCreateView` (which is how all the other dialogs do it) seems to fix the problem.
That version supports incremental annotation processing. Gradle was previously complaining about the lack thereof.
Show case in timer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192.
Build Issues
The app wasn't compiling when I first cloned it, so I had to make some changes.
com.takisoft.fix:preference-v7:26.0.1.0andcom.pavelsikun:vintage-chroma:1.5(as discussed here). I swapped outcom.takisoft.fix:preference-v7forandroidx.preference, since it was only used in one or two places. Thevintage-chromadependency was used much more and I couldn't find any repositories that have it, so I cloned the project and added it as a submodule.getDialog().getWindow().requestFeature(Window.FEATURE_NO_TITLE)fromonViewCreatedtoonCreateViewseems to have solved it.New Trainer
I added a new trainer for 3-style corners. I mostly followed the implementation of the OLL and PLL trainers. However, I let users select cases using a regular expression since it would be inconvenient to list all 420 cases. I also let the user customize their letter scheme and buffer. And to ensure the app doesn't always give the same scramble for the same case (which would sometimes give away which case it is), I add a random prefix and suffix to the scramble.