Skip to content

Dismiss search on touch suggestions list margins #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduardbosch wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Dismiss search on touch suggestions list margins #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f72f61
fix: Dismiss search on touch suggestions list margins
Jul 18, 2017
65f923d
feat: Allow compiling in jitpack
Jul 18, 2017
4421acd
fix: Missing setEnabled to itself
Jul 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:2.3.0'

classpath 'com.github.dcendents:android-maven-gradle-plugin:1.5'

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
Expand Down
3 changes: 3 additions & 0 deletions library/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
apply plugin: 'com.android.library'
apply plugin: 'com.github.dcendents.android-maven'

group='com.github.arimorty'

android {
compileSdkVersion 25
Expand Down
9 changes: 4 additions & 5 deletions library/src/main/java/com/arlib/floatingsearchview/FloatingSearchView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

/**
Expand Down Expand Up @@ -439,7 +438,7 @@ public void onGlobalLayout() {

private void setupViews(AttributeSet attrs) {

mSuggestionsSection.setEnabled(false);
setEnabled(false);

if (attrs != null) {
applyXmlAttributes(attrs);
Expand Down Expand Up @@ -1123,7 +1122,7 @@ public void setCloseSearchOnKeyboardDismiss(boolean closeSearchOnKeyboardDismiss
public void setDismissOnOutsideClick(boolean enable) {

mDismissOnOutsideTouch = enable;
mSuggestionsSection.setOnTouchListener(new OnTouchListener() {
setOnTouchListener(new OnTouchListener() {
@Override
public boolean onTouch(View v, MotionEvent event) {

Expand Down Expand Up @@ -1523,7 +1522,7 @@ private void setSearchFocusedInternal(final boolean focused) {

//if we don't have focus, we want to allow the client's views below our invisible
//screen-covering view to handle touches
mSuggestionsSection.setEnabled(focused);
setEnabled(focused);
}

private void changeIcon(ImageView imageView, Drawable newIcon, boolean withAnim) {
Expand Down Expand Up @@ -1870,7 +1869,7 @@ public void onRestoreInstanceState(Parcelable state) {
setCloseSearchOnKeyboardDismiss(savedState.dismissOnSoftKeyboardDismiss);
setDismissFocusOnItemSelection(savedState.dismissFocusOnSuggestionItemClick);

mSuggestionsSection.setEnabled(mIsFocused);
setEnabled(mIsFocused);
if (mIsFocused) {

mBackgroundDrawable.setAlpha(BACKGROUND_DRAWABLE_ALPHA_SEARCH_FOCUSED);
Expand Down