Skip to content

Wrong calculation of suggestions list height #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduardbosch wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Wrong calculation of suggestions list height #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion library/src/main/java/com/arlib/floatingsearchview/FloatingSearchView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

/**
Expand Down Expand Up @@ -1425,9 +1424,15 @@ public void onAnimationCancel(View view) {
//returns the cumulative height that the current suggestion items take up or the given max if the
//results is >= max. The max option allows us to avoid doing unnecessary and potentially long calculations.
private int calculateSuggestionItemsHeight(List<? extends SearchSuggestion> suggestions, int max) {
if (mSuggestionsList.getChildCount() < suggestions.size()) {
return max;
}

//todo
// 'i < suggestions.size()' in the below 'for' seems unneeded, investigate if there is a use for it.
// NOTE ebosch: 20/07/2017 I think 'i < suggestions.size()' might be here to avoid
// calculating more children than the number of current suggestions. But if this happens
// might be that mSuggestionsList has not already been populated with new suggestions items.
int visibleItemsHeight = 0;
for (int i = 0; i < suggestions.size() && i < mSuggestionsList.getChildCount(); i++) {
visibleItemsHeight += mSuggestionsList.getChildAt(i).getHeight();
Expand Down