Skip to content

fix right buttons translations for rtl #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drobyshys wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix right buttons translations for rtl #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions library/src/main/java/com/arlib/floatingsearchview/FloatingSearchView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,21 +710,22 @@ public void onClick(View v) {
//ensures that the end margin of the search input is according to Material specs
private void handleOnVisibleMenuItemsWidthChanged(int menuItemsWidth) {
if (menuItemsWidth == 0) {
mClearButton.setTranslationX(-Util.dpToPx(4));
int translationX = Util.dpToPx(4);
mClearButton.setTranslationX(isRTL() ? translationX : -translationX);
int paddingRight = Util.dpToPx(4);
if (mIsFocused) {
paddingRight += Util.dpToPx(CLEAR_BTN_WIDTH_DP);
} else {
paddingRight += Util.dpToPx(14);
}
mSearchInput.setPadding(0, 0, paddingRight, 0);
mSearchInput.setPadding(isRTL() ? paddingRight : 0, 0, isRTL() ? 0 : paddingRight, 0);
} else {
mClearButton.setTranslationX(-menuItemsWidth);
mClearButton.setTranslationX(isRTL() ? menuItemsWidth : -menuItemsWidth);
int paddingRight = menuItemsWidth;
if (mIsFocused) {
paddingRight += Util.dpToPx(CLEAR_BTN_WIDTH_DP);
}
mSearchInput.setPadding(0, 0, paddingRight, 0);
mSearchInput.setPadding(isRTL() ? paddingRight : 0, 0, isRTL() ? 0 : paddingRight, 0);
}
}

Expand Down Expand Up @@ -958,7 +959,7 @@ private void refreshLeftIcon() {
queryTranslationX = -leftActionWidthAndMarginLeft;
break;
}
mSearchInputParent.setTranslationX(queryTranslationX);
mSearchInputParent.setTranslationX(isRTL() ? -queryTranslationX : queryTranslationX);
}

private void toggleLeftMenu() {
Expand Down