Repository navigation
Reject embedded NUL bytes before forwarding HTTP headers - #5
Merged
Merged
Conversation
Signed-off-by: Arin Aeruva <43118055+arin30@users.noreply.github.com>
Use a byte-bounded header terminator search so embedded NUL bytes reach parser validation. Verify malformed requests never reach the backend, with a valid forwarding control. Signed-off-by: Arin Aeruva <43118055+arin30@users.noreply.github.com>
arin30
marked this pull request as ready for review
October 26, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request-line and header fields must not be truncated at embedded NUL bytes. This rejects them in the parser and uses a byte-bounded terminator search in the socket reader so validation actually runs.
Coverage includes NUL bytes in the method, target, version, header name and value. The network regression asserts HTTP 400 for all five cases, no backend requests, and successful forwarding of a valid control request. The parser also accepts binary NUL bytes in a request body.
Validation: make check, make tls and git diff --check passed locally. The network test failed before the socket-reader fix and passed afterward. Local LeakSanitizer cannot run under this environment's process restrictions, so sanitizer validation is pending the existing Ubuntu CI job.