Harden side-chat screenshot readiness - #61
Open
ariofrio wants to merge 1 commit into
Open
Conversation
The failed capture did not distinguish a lost shortcut from a slow panel because both ended at the composer timeout. Retry only while createSideChat is absent, then give panel rendering its own deadline. Upload the isolated bb log on failure.
ariofrio
force-pushed
the
ariofrio/harden-side-chat-screenshot
branch
from
August 27, 2026 08:37
31618bf to
0c62be9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the side-chat screenshot retry only while the shortcut has not reached
createSideChat, then wait independently for the panel to render. Preserve the isolated bb log when capture fails.Purpose
The PR 51 capture failure timed out waiting for the Reply composer after ⇧⌘L. The retry added in
f632be4also uses composer visibility to decide whether the shortcut was lost, so it cannot distinguish a missed keypress from a side chat whose panel is still rendering.Changes
createSideChatresponse listener before each ⇧⌘L attempt..scratch/screenshots/bb.logafter a failed capture.Evidence
createSideChatattempts but currentmainobserved zero.npm run check:layout,npm run check:ui, andnpm run check:heading-iconspassed.Caveats
This changes only the screenshot harness and workflow, so it has no changeset or committed screenshot update. CI remains the authoritative renderer.
Written by Codex