Sync source-of-truth roast_pack.json with the bundled app copy - #5
Merged
Merged
Conversation
assets/roast_pack_v1/roast_pack.json (the "source of truth" per tech plan §7) had drifted from app/android/core/src/main/assets/roast_pack_v1/ roast_pack.json — the latter got the v3 intent-text removal (b6a89d4), the former didn't. Building a remote pack release from the stale root copy would have silently re-shipped the removed {intent}-quoting templates. Copies the bundled v3 content over so there's one real source again. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01APiUERJLZddCPpd8gJ94R4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found this while building the roast pack v2 remote release:
assets/roast_pack_v1/roast_pack.json(the documented "source of truth" per tech plan §7) had drifted fromapp/android/core/src/main/assets/roast_pack_v1/roast_pack.json— the bundled copy got the v3 intent-text removal (b6a89d4: "dropped every template that quoted the user's own excuse text back at them"), the root copy didn't.Building a remote pack release from the stale root copy would have silently re-shipped the 15 removed
{intent}-quoting templates into a "new" pack push — exactly the kind of regression the whole point of T-207 (remote copy packs) is supposed to let you avoid needing an app rebuild to fix.Change
Copies the current bundled
roast_pack.json(version 3, 33 templates, no intent-text templates) over the root copy — one real source again.Test plan
🤖 Generated with Claude Code
Generated by Claude Code