Fixes debian 8 and centos 7#44
Open
MassiveHiggsField wants to merge 9 commits into
Open
Conversation
…ding a start shell script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This role currently doesn't work on debian 8 and centos 7, because the xvfb-run call in the systemd service file has problems passing the parameters to xvfb. There is a test which should make sure the service is correctly started, but because of a timing issue (service gets started correctly but exits after some seconds) this doesn't work.
I've fixed the parameter issue by adding a new start shell script and calling that from the service file. Additionally i've added a new test which waits for the message "Selenium Server up and running" to really make sure the server is up.