fix(alerts): não disparar CRITICAL quando não houver bateria - #9
Merged
Merged
Conversation
Desktop ou ioreg vazio devolve percent=0 e design=0. O launchd a cada 15 min avisava para plugar o carregador. Sem DesignCapacity o comando agora sai quieto; MacBook em 0% real continua alertando.
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Em Mac desktop (ou quando o
ioregvem vazio)get_battery()devolvepercent=0edesign_capacity_mah=0. Olaunchda cada 15 min disparava "Battery CRITICAL at 0%! Plug in the charger now." Agora, semDesignCapacity,mm alertssai quieto. MacBook com bateria real em 0% continua alertando.Tipo de mudança
Issues relacionadas
—
Saída
Antes (desktop / ioreg vazio):
Depois:
Checklist
mainmais recente (já inclui o fix(ui): escapar markup Rich em texto que vem do sistema #8).pytestpassou localmente (223 testes).CHANGELOG.mdem[Unreleased].COMMANDS.mdna seção demm alerts.Notas para revisão
BatteryInfo.is_present()olha sódesign_capacity_mah > 0— é o sinal estável de que o AppleSmartBattery existe. Próximos PRs: realocarLOGS_DIR, validação da CLI, interface ativa + não cachear IP públicoNone.