Skip to content

Fix four build failures on macOS / clang #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlagedo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix four build failures on macOS / clang #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e876381
Point IMGUI_USER_CONFIG at the header's actual name
jlagedo Sep 5, 2026
b948cab
Include the generated header under the name UHT actually emits
jlagedo Sep 5, 2026
f1c6d41
Do not pass reflected property text as a format string
jlagedo Sep 5, 2026
a3bc787
Export FCogLogOutputDevice so other modules can construct the window
jlagedo Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Plugins/Cog/Source/CogEngine/Private/CogEngineWindow_Inspector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ bool FCogEngineWindow_Inspector::RenderProperty(const FProperty* Property, uint8
ImGui::TableNextColumn();
ImGui::Text("DisplayName:");
ImGui::TableNextColumn();
ImGui::Text(TCHAR_TO_UTF8(*Property->GetDisplayNameText().ToString()));
ImGui::Text("%s", TCHAR_TO_UTF8(*Property->GetDisplayNameText().ToString()));
#endif // WITH_EDITORONLY_DATA

ImGui::TableNextRow();
Expand All @@ -533,7 +533,7 @@ bool FCogEngineWindow_Inspector::RenderProperty(const FProperty* Property, uint8
ImGui::TableNextColumn();
if (Property->HasMetaData("Tooltip"))
{
ImGui::Text(TCHAR_TO_UTF8(*Property->GetToolTipText(false).ToString()));
ImGui::Text("%s", TCHAR_TO_UTF8(*Property->GetToolTipText(false).ToString()));
}
#endif // WITH_EDITORONLY_DATA

Expand All @@ -551,7 +551,7 @@ bool FCogEngineWindow_Inspector::RenderProperty(const FProperty* Property, uint8
ImGui::BeginTooltip();
ImGui::PushTextWrapPos(ImGui::GetFontSize() * 35.0f);

ImGui::Text(TCHAR_TO_UTF8(*Property->GetToolTipText(false).ToString()));
ImGui::Text("%s", TCHAR_TO_UTF8(*Property->GetToolTipText(false).ToString()));
ImGui::Text("Details [CTRL]");
ImGui::PopTextWrapPos();
ImGui::EndTooltip();
Expand Down
2 changes: 1 addition & 1 deletion Plugins/Cog/Source/CogEngine/Public/CogEngineWindow_NetImGui.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include "CoreMinimal.h"
#include "CogCommonConfig.h"
#include "CogWindow.h"
#include "CogEngineWindow_NetImgui.generated.h"
#include "CogEngineWindow_NetImGui.generated.h"

class UCogEngineWindowConfig_NetImgui;

Expand Down
2 changes: 1 addition & 1 deletion Plugins/Cog/Source/CogEngine/Public/CogEngineWindow_OutputLog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class UCogEngineConfig_OutputLog;
class FCogEngineWindow_OutputLog;

//--------------------------------------------------------------------------------------------------------------------------
class FCogLogOutputDevice : public FOutputDevice
class COGENGINE_API FCogLogOutputDevice : public FOutputDevice
{
public:
friend class FCogEngineWindow_OutputLog;
Expand Down
2 changes: 1 addition & 1 deletion Plugins/Cog/Source/CogImgui/CogImgui.Build.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public CogImgui(ReadOnlyTargetRules Target) : base(Target)
});
}

PublicDefinitions.Add("IMGUI_USER_CONFIG=\"CogImGuiConfig.h\"");
PublicDefinitions.Add("IMGUI_USER_CONFIG=\"CogImguiConfig.h\"");
PublicDefinitions.Add("IMGUI_API=COGIMGUI_API");
PublicDefinitions.Add("IMPLOT_API=COGIMGUI_API");
}
Expand Down