fix(proxy): isolate session context by session_key and task-label header#185
Open
fix(proxy): isolate session context by session_key and task-label header#185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
What changed
session_keyin the/sessionpayload it sends to the proxy.x-agentweave-session-keyalongside that context push so subsequent LLM requests can resolve the matching per-session forced context.x-agentweave-task-labelas a request-level path forprov.task.label, instead of relying only on the shared session-context fallback.task_labelparameter threading bug in the proxy trace helpers that was causing aNameErrorin the test suite.Why this fixes the issue
Before this change, the proxy already had
_forced_session_contexts, but the OpenClaw bridge was still posting/sessionwithoutsession_key, so most traffic continued down the legacy global_session_contextpath. That meant concurrent agents could still stomp each other's task/session attribution.This change completes the end-to-end path:
session_keysession_keyprov.task.labelcan come from a per-request header pathTests
Result:
164 passed in 0.68sNotes