Conversation
weakpool is based on weak.Pointer, only works on go 1.24+
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## lua5.5 #123 +/- ##
===========================================
- Coverage 80.79% 67.36% -13.43%
===========================================
Files 168 170 +2
Lines 15144 15602 +458
===========================================
- Hits 12235 10511 -1724
- Misses 2549 4756 +2207
+ Partials 360 335 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since go 1.24 weak pointers are available via the
weakstdlib package. This means we can now have a GC pool with similar characteristics asluagc.UnsafePoolbut implemented safely in Go. We get further simplifications by usingruntime.AddCleanupinstead ofruntime.SetFinalizer.We could remove all other
luagc.Poolimplementations in the future I think but for now that would mean we require go1.24 (which is a big just from go1.18 currently)