Skip to content

Fix crash on outgoing calls. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnonym merged 1 commit into from
Feb 1, 2026
+6 −3
Merged

Fix crash on outgoing calls. #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ha-sip/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

If you find ha-sip useful, consider starring ⭐ the [GitHub repo](https://github.com/arnonym/ha-plugins)!

# 5.4.1
- Fix crash for outgoing calls

## 5.4
- Allow templating of messages in `incoming_call_file` or from MQTT (thanks nbe95@github for implementing this!)
- Add option to extract SIP headers and receive them in webhooks
Expand Down
2 changes: 1 addition & 1 deletion ha-sip/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ha-sip",
"version": "5.4",
"version": "5.4.1",
"slug": "ha-sip",
"url": "https://github.com/arnonym/ha-plugins",
"description": "Home-Assistant SIP Gateway",
Expand Down
4 changes: 2 additions & 2 deletions ha-sip/src/call.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,11 +506,11 @@ def send_dtmf(self, digits: str, method: DtmfMethod = 'in_band') -> None:
self.sendDtmf(dtmf_prm)

def get_callback_ids(self) -> tuple[str, List[str]]:
call_info = self.get_call_info()
if self.uri_to_call:
# On outgoing calls we use the uri_to_call, as other info is not available yet
parsed_caller = self.parse_caller(self.uri_to_call)
return self.uri_to_call, [x for x in [parsed_caller, call_info['call_id']] if x is not None]
return self.uri_to_call, [x for x in [parsed_caller] if x is not None]
call_info = self.get_call_info()
return call_info['remote_uri'], [x for x in [call_info['parsed_caller'], call_info['call_id']] if x is not None]

def get_call_info(self) -> webhook.CallInfo:
Expand Down
Loading