Skip to content

test: move chemical-heat spit cases into scene_tests/spit - #128

Merged
arnoudja merged 1 commit into
masterfrom
cursor/spit-tests-theme-e376
Sep 28, 2026
Merged

arnoudja merged 1 commit into
masterfrom
cursor/spit-tests-theme-e376

Conversation

@arnoudja

Copy link
Copy Markdown
Owner

Summary

Locked maintainability slice (post-#127 suggestion #1 only): move generic chemical-heat spit tests out of the H₂SO₄ theme into a dedicated scene_tests/spit module, and add one kinetic-dissolve spit coverage case.

Changes

  • New crates/chemlab-core/src/scene_tests/spit.rs — spit_count / solution_ml + four moved tests + kinetic_naoh_hot_dump_spits_at_most_once_clock_keeps_mass
  • Trim spit helpers/tests from scene_tests/h2so4.rs (H₂SO₄-specific tests stay)
  • Register mod spit in scene_tests/mod.rs

New test

kinetic_naoh_hot_dump_spits_at_most_once_clock_keeps_mass — tongs NaOH into near-boil water: action spit = 1; after apply_elapsed, spit count stays 1 and volume unchanged (clock clamp-only / no mass discard).

Out of scope

FE spit-cue collapse, Φ_V extract, dilution twin collapse, scene spit helpers, aqueous_pipeline gate, burner, features, reformats, re-doing #123/#126/#127.

Verify

cargo test -p chemlab-core --lib → 272 passed.

Open in Web Open in Cursor 

Extract spit_count/solution_ml and the four generic spit tests from
h2so4 into a dedicated spit theme, and cover kinetic NaOH dump spit
(action ≤1; clock no mass discard).

Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
@arnoudja
arnoudja marked this pull request as ready for review September 28, 2026 18:22
@arnoudja
arnoudja merged commit 65b8006 into master Sep 28, 2026
12 checks passed
@arnoudja
arnoudja deleted the cursor/spit-tests-theme-e376 branch September 28, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants