Repository navigation
test: move chemical-heat spit cases into scene_tests/spit - #128
Merged
Merged
Conversation
Extract spit_count/solution_ml and the four generic spit tests from h2so4 into a dedicated spit theme, and cover kinetic NaOH dump spit (action ≤1; clock no mass discard). Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locked maintainability slice (post-#127 suggestion #1 only): move generic chemical-heat spit tests out of the H₂SO₄ theme into a dedicated
scene_tests/spitmodule, and add one kinetic-dissolve spit coverage case.Changes
crates/chemlab-core/src/scene_tests/spit.rs—spit_count/solution_ml+ four moved tests +kinetic_naoh_hot_dump_spits_at_most_once_clock_keeps_massscene_tests/h2so4.rs(H₂SO₄-specific tests stay)mod spitinscene_tests/mod.rsNew test
kinetic_naoh_hot_dump_spits_at_most_once_clock_keeps_mass— tongs NaOH into near-boil water: action spit = 1; afterapply_elapsed, spit count stays 1 and volume unchanged (clock clamp-only / no mass discard).Out of scope
FE spit-cue collapse, Φ_V extract, dilution twin collapse, scene spit helpers, aqueous_pipeline gate, burner, features, reformats, re-doing #123/#126/#127.
Verify
cargo test -p chemlab-core --lib→ 272 passed.