Various fixes [read below]#5
Open
fterrier wants to merge 27 commits into
Open
Conversation
…to roboli-master Conflicts: src/arosequist/om_autocomplete/bootstrap.cljs
Author
|
Hi @arosequist, @swannodette, I've added a few commits to the PR and changed the module quite a lot:
Franz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @arosequist,
Thanks for the great library, I use it and it seems to work quite well.
Here's a pull request with a few proposals on things that can be improved:
being visible at some point, it was pushing the content down a few pixels so I've set that to "display: none;"- I've refactored the way the channels are created and killed in order to fix some potential race conditions. I'm not sure about that one perhaps you want to have a good second look?
- I've added a IWilUnmount that closes all the channels
- I've merged @robili's branch as well
Let me know what you think,
Franz
This change is