Eliminate remaining allocations in read operations (Map.Get/Has, Set.Has) - #91
Merged
Conversation
…Has) Use reflect.Kind dispatch in resolveHashFunc, resolveSeededHashFunc, and EqualFuncFor to catch derived types (e.g., type MyFloat float64) and route them through direct hash/equality functions instead of boxing through interface fallbacks. Add size-based integer fast-paths to resolveSeededHashFunc. Add Map.Has and Set.Has benchmarks. All read benchmarks now report 0 B/op, 0 allocs/op at 1k and 1M sizes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Split resolveHashFunc and resolveSeededHashFunc into kind-based and size-based halves. Merge Complex64/Complex128 cases in resolveHashFunc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use reflect.Kind dispatch in resolveHashFunc, resolveSeededHashFunc, and
EqualFuncFor to catch derived types (e.g., type MyFloat float64) and
route them through direct hash/equality functions instead of boxing
through interface fallbacks. Add size-based integer fast-paths to
resolveSeededHashFunc. Add Map.Has and Set.Has benchmarks.
All read benchmarks now report 0 B/op, 0 allocs/op at 1k and 1M sizes.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com