Skip to content

Fix blocked tab tree view collapsing on model updates#311

Merged
arran4 merged 2 commits into
mainfrom
fix-blocked-tab-collapse-13318563239511025353
Jun 18, 2026
Merged

Fix blocked tab tree view collapsing on model updates#311
arran4 merged 2 commits into
mainfrom
fix-blocked-tab-collapse-13318563239511025353

Conversation

@arran4

@arran4 arran4 commented May 30, 2026

Copy link
Copy Markdown
Owner

Fix blocked tab tree view collapsing on model updates

The blocked tab tree view was constantly collapsing when underlying data refreshed because BlockedTreeModel rebuilt the entire tree (triggering modelReset and layoutChanged).

This connects the m_blockedTreeModel's modelReset and layoutChanged signals directly to the m_blockedView's expandAll slot so it always stays open.


PR created automatically by Jules for task 13318563239511025353 started by @arran4

The blocked tab tree view was constantly collapsing when underlying data refreshed because `BlockedTreeModel` rebuilt the entire tree (triggering `modelReset` and `layoutChanged`).

This connects the `m_blockedTreeModel`'s `modelReset` and `layoutChanged` signals directly to the `m_blockedView`'s `expandAll` slot so it always stays open.

Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds connections to automatically expand all items in the blocked tree view when the model resets or its layout changes. The review feedback points out that connecting both signals is redundant and inefficient, causing double execution of expandAll. It suggests using a single connection with Qt::QueuedConnection on modelReset to ensure the view is fully updated and avoid redundant layout calculations.

Comment thread src/mainwindow.cpp Outdated
The blocked tab tree view was constantly collapsing when underlying data refreshed because `BlockedTreeModel` rebuilt the entire tree (triggering `modelReset`).

This connects the `m_blockedTreeModel`'s `modelReset` signal directly to the `m_blockedView`'s `expandAll` slot using `Qt::QueuedConnection` to reliably keep it open.

Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
@arran4 arran4 merged commit 576f95e into main Jun 18, 2026
26 checks passed
@arran4 arran4 deleted the fix-blocked-tab-collapse-13318563239511025353 branch June 18, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant