Fix blocked tab tree view collapsing on model updates#311
Conversation
The blocked tab tree view was constantly collapsing when underlying data refreshed because `BlockedTreeModel` rebuilt the entire tree (triggering `modelReset` and `layoutChanged`). This connects the `m_blockedTreeModel`'s `modelReset` and `layoutChanged` signals directly to the `m_blockedView`'s `expandAll` slot so it always stays open. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request adds connections to automatically expand all items in the blocked tree view when the model resets or its layout changes. The review feedback points out that connecting both signals is redundant and inefficient, causing double execution of expandAll. It suggests using a single connection with Qt::QueuedConnection on modelReset to ensure the view is fully updated and avoid redundant layout calculations.
The blocked tab tree view was constantly collapsing when underlying data refreshed because `BlockedTreeModel` rebuilt the entire tree (triggering `modelReset`). This connects the `m_blockedTreeModel`'s `modelReset` signal directly to the `m_blockedView`'s `expandAll` slot using `Qt::QueuedConnection` to reliably keep it open. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Fix blocked tab tree view collapsing on model updates
The blocked tab tree view was constantly collapsing when underlying data refreshed because
BlockedTreeModelrebuilt the entire tree (triggeringmodelResetandlayoutChanged).This connects the
m_blockedTreeModel'smodelResetandlayoutChangedsignals directly to them_blockedView'sexpandAllslot so it always stays open.PR created automatically by Jules for task 13318563239511025353 started by @arran4