Repository navigation
fix: implement SSH host key verification to prevent MitM attacks - #42
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Add HostKeyCallback() in pkg/proxy that supports two verification modes: - SSH_KNOWN_HOSTS_FILE: OpenSSH known_hosts file verification - SSH_HOST_KEY: base64-encoded pinned public key verification Fail-closed: if neither env var is set, connections are rejected. Add tests for host key mismatch, match, known_hosts, and unconfigured cases. Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
ssh.InsecureIgnoreHostKey()inpkg/proxy/proxy.gowith a fail-closedHostKeyCallback()that supports two verification modes via environment variables:SSH_KNOWN_HOSTS_FILE— path to an OpenSSHknown_hostsfile, verified viaknownhosts.New()SSH_HOST_KEY— base64-encoded raw public key for pinning (e.g. fromssh-keyscan | awk '{print $3}')If neither is set,
DialThroughBoundaryreturns an error — no silent fallback to insecure mode.New file
pkg/proxy/hostkey.gocontainsHostKeyCallback(),ErrHostKeyMismatch, and the pinned/known_hosts callbacks.Tests added in
main_test.go:TestHostKeyMismatch— pins wrong key, assertsErrHostKeyMismatchTestHostKeyMatch— pins correct key, asserts successful connectionTestHostKeyCallback_NeitherConfigured— asserts error when unconfiguredTestHostKeyCallback_KnownHostsFile— writes a temp known_hosts, verifies acceptanceFixes #13
Link to Devin session: https://app.devin.ai/sessions/2a885a94e7464a9993c6f40865502ea9