Fix feed latency TypeError and flaky integration test#17
Merged
Conversation
- Cast WebSocket ts to int before arithmetic in Feed and AsyncFeed (API sends ts as string, causing TypeError in latency_ms) - Remove overly strict assertion in integration test that assumed status=open only returns active markets - Bump version to 1.0.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeErrorinFeed.latency_ms/AsyncFeed.latency_ms— the API sendstsas a string but the code didfloat - str. Cast tointon store.test_get_markets_with_status_filterthat assumedstatus=openonly returnsactivemarkets (API can returnclosed).Test plan
test_latency_calculated_from_timestampsstill passes