Treat null list-typed responses as empty (1.0.6)#20
Merged
Conversation
Kalshi sometimes returns ``{"key": null}`` instead of ``{"key": []}`` or
omitting the key entirely. ``dict.get(key, default)`` only uses the
default for missing keys, so iteration over a None response crashed
with TypeError. Switch every list-extraction call site to
``dict.get(key) or []`` to handle both null and missing.
Affects: paginated list helper, multi-market candlesticks, batch order
place/cancel, queue positions, order groups, subaccount balances,
historical candlesticks, exchange announcements, and api_keys list.
Also stop the test_get_queue_position cleanup from blowing up when the
order is already gone (filled mid-test).
Bumps version to 1.0.6.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{\"key\": null}for list-typed payload fields instead of{\"key\": []}or omitting the key.dict.get(key, [])only falls back to[]for missing keys — when the key is present with valuenull, iteration crashes withTypeError: 'NoneType' object is not iterable. This caused the integration suite'stest_get_queue_positions_multiplefailure on PR Fix WebSocket ts parsing for ISO 8601 timestamps (closes #18) #19's CI run.dict.get(key) or []so both null and missing are handled.test_get_queue_position's cleanup from raising when the order was already filled mid-test.Bumps version to 1.0.6.
Test plan
pytest tests/(unit) — 301 passed🤖 Generated with Claude Code