Merged
Conversation
fabid
reviewed
Feb 24, 2026
fabid
left a comment
fabid
left a comment
There was a problem hiding this comment.
thank you. Does it mean we should consider updating the artefacts.yaml spec/ CLI to better support the ARTEFACTS_UPLOAD_DIR, especially since we want to deprecated ros topic based metrics
Contributor
Author
|
Indeed. A simple one could just be allowing environment variables in the yaml file. I attempted but didnt have any luck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dont believe there is a good way to have the
artefacts.yamllook for the tmp dir (of the run) wheremetrics.jsonwas being placed beforehand. This PR just changes the location of where metrics are being placed to the root of the repo. As a result shows up properly on the project page in dashboard.Also updated the readme with a clarification of why
artefactsis not part of the uv environment (psutil discrepancy, where isaac is using quite an old version)