feature: fix compaction and other fixes - #100
Merged
Merged
Conversation
- Replace `LazyVStack` with `VStack` in `AppIconSelectionView` - Keep the existing leading alignment and spacing for the settings layout
- Add inputRevision to chat loaded state and input bar state - Increment inputRevision when input text changes, clears, or is transcribed - Refactor chat input bar to manage local text state and send entered text explicitly - Update chat view send flow to forward input text before dispatching send - Extend tests to verify inputRevision updates on persistence, transcription, and repeated input
- Introduce request-context preparation that compacts overflowing conversations before streaming or agent execution - Persist compacted summaries before sending regular or agent requests and surface a new automatic compaction failure error - Move compaction scheduling and configuration helpers into a dedicated view model extension - Update agent and streaming paths to await the new request-context preparation flow - Expand test mocks to support multiple compaction results and capture sent message batches - Add tests covering compaction before regular chat requests and agent requests
- Treat existing and generated summaries as untrusted data in compaction prompts and context window prompts - Encode existing summaries as JSON payloads and update prompt text to forbid following embedded instructions - Validate compaction responses against token limits and reject empty or oversized summaries - Add rollback support for pending preflight compaction when persistence or streaming state changes - Remove compaction task cancellation from unrelated chat actions and rely on preflight summary tracking - Update compaction and context window tests for untrusted summary handling and rollback behavior
- Persist compacted summaries before the first overflowing request - Roll back pending summaries when saving, cancellation, or expiration interrupts compaction - Include actual agent system instructions in context estimates - Treat compacted conversation summaries as size-bounded untrusted data before reuse - Update changelog and TestFlight release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.