Merged
Conversation
Owner
|
This is great, thank you. Can you also add it to unsink? While it can be reproduced with peek+remove there, avoiding the second hashmap lookup is still relevant. |
Contributor
Author
Makes sense, done! |
This method removes the entry from cache for a given key only if a provided predicate returns true for the entry's value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this crate, it's awesome! One thing that was missing for me is ability to remove the entry only if its value matches what I expect. I've added
Cache::remove_ifwhich makes it possible to achieve that.I've added it only for thesyncversion of theCache, as withunsyncversion you can just dopeek+remove, but let me know if I should add it tounsynctoo for consistency.