Skip to content

Making this package an Express 4 Router - #1

Open
colthreepv wants to merge 4 commits into
arthurtsang:masterfrom
colthreepv:master
Open

Making this package an Express 4 Router#1
colthreepv wants to merge 4 commits into
arthurtsang:masterfrom
colthreepv:master

Conversation

@colthreepv

Copy link
Copy Markdown

Hello @arthurtsang, I'm making this PR mostly to thank you for this awesome fork and inspiration.

I made this fork into an Express Router, so people can mount it in their development server on an arbitrary endpoint (ex: localhost:8080/edit-raml)

I'm making this PR and a full repository dedicated to it, since I think could use way more documentation.

@justjacksonn

Copy link
Copy Markdown

Hi,

I would like to grab your changes but also see about updating the raml-api-designer to the latest. There is a fresh UI for the side-bar generated documentation that would be nice to see in the designer.

@colthreepv

Copy link
Copy Markdown
Author

I appreciate your feedback, but I'm doubtful this outdated PR is still working.
Since i published it, I had to make a full-fledged rework of your work to make it work smoothly...

Just double-check it in case you are interested in merging, and ping me here to fix it

@arthurtsang

Copy link
Copy Markdown
Owner

hi @MrGamer , sorry, somehow the notification is buried in my tons of notification (from other repo that i followed) and thanks for your PR, i'd apprepricate the update. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants