feat(chart): add extraManifests and backend.environmentSecrets#121
feat(chart): add extraManifests and backend.environmentSecrets#121oba11 wants to merge 3 commits into
Conversation
|
Hey @brandonrc — quick ping when you have a moment 🙏 All required checks are green. The only red is SonarCloud Scan, which fails because Happy to tweak anything else. Thanks! |
b029b0f to
7b5d66d
Compare
|
Thanks for the PR. The one required check failing here is Verify helm-docs output: the chart README needs regenerating after the values change. Could you run this from the repo root and commit the result? (helm-docs v1.14.2, matching Heads up: the red SonarCloud Scan is a known non-blocking issue on fork PRs. GitHub withholds |
Lets operators source backend env vars (e.g. OTEL_EXPORTER_OTLP_HEADERS) from existing Secrets and ship arbitrary Kubernetes objects (ExternalSecret, SealedSecret, custom CRs) alongside the release without forking the chart. Refs artifact-keeper#120
32179e1 to
b743677
Compare
b743677 to
be48e83
Compare
|
Thanks @brandonrc, I've regenerated the chart README and all good now. |
|
@brandonrc just want to check again on the merge-ability of this pull request. Thanks alot for your help |
Closes #120
Summary
backend.environmentSecrets— list of env vars sourced from existing Secrets viasecretKeyRef, rendered into the backend container'senv:.extraManifests— list of raw, templated manifests rendered as additional documents (tpl . $), so chart helpers like{{ include "artifact-keeper.fullname" . }}work inside entries.OTEL_EXPORTER_OTLP_HEADERSsecurely by shipping anExternalSecretviaextraManifestsand injecting its value viabackend.environmentSecrets— no plaintext in values, no second Argo Application.Test plan
helm lint charts/artifact-keeperpasses.helm templatewith both new values set renders the expectedsecretKeyRefentry under the backend container'senv:and emits the extra manifest as its own document.environmentSecrets: [],extraManifests: []) produce no diff vs. main when unset.