Skip to content

feat(chart): add existingSecret wiring #157

Open
AmmonsIO wants to merge 1 commit into
artifact-keeper:mainfrom
AmmonsIO:main
Open

feat(chart): add existingSecret wiring #157
AmmonsIO wants to merge 1 commit into
artifact-keeper:mainfrom
AmmonsIO:main

Conversation

@AmmonsIO

@AmmonsIO AmmonsIO commented Jun 5, 2026

Copy link
Copy Markdown

Summary

This adds a secrets.existingSecrets value that will override the creation of a secret in cluster without having to have external secrets operator. If a user is using encrypted secrets yamls or a secrets operator other than ESO they currently need to make and maintain modifications to the chart. This sets up the infrastructure for them to just reference an existing secret. It includes what the expected values in the secret should be. It also sets up a helper function for determining what the secret name that should be referenced by the deployments are.

Closes #158

Test Checklist

  • Helm template renders without errors
  • [] Terraform validates/plans cleanly
  • [] Manually verified on staging cluster (if applicable)
  • [] Rollback strategy documented

Infrastructure

  • Helm: helm template renders correctly
  • [] Terraform: terraform validate passes
  • [] Terraform: terraform plan shows expected changes
  • [] ArgoCD: Application manifests are valid
  • [] N/A - documentation only

@AmmonsIO AmmonsIO requested a review from a team as a code owner June 5, 2026 11:20
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Missing linked issue

This PR does not reference a tracking issue in its body. Every PR must link to an issue in this repository so we can trace work back to a planned change.

How to fix

  1. Edit the PR description and add a line like Closes #123, Fixes #123, or Resolves #123 referring to an open issue in artifact-keeper/artifact-keeper-iac.
  2. Save the description. This check will re-run automatically.

Accepted keywords (case-insensitive, any tense): close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved.

Policy reference: see the PR template.

Maintainer bypass: apply the no-issue-required label to this PR to skip the check (use sparingly, e.g. for trivial typo fixes or release-tag chores).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow use of an existing secret

1 participant