feat(chart): add existingSecret wiring #157
Open
AmmonsIO wants to merge 1 commit into
Open
Conversation
Missing linked issueThis PR does not reference a tracking issue in its body. Every PR must link to an issue in this repository so we can trace work back to a planned change. How to fix
Accepted keywords (case-insensitive, any tense): Policy reference: see the PR template. Maintainer bypass: apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a secrets.existingSecrets value that will override the creation of a secret in cluster without having to have external secrets operator. If a user is using encrypted secrets yamls or a secrets operator other than ESO they currently need to make and maintain modifications to the chart. This sets up the infrastructure for them to just reference an existing secret. It includes what the expected values in the secret should be. It also sets up a helper function for determining what the secret name that should be referenced by the deployments are.
Closes #158
Test Checklist
Infrastructure
helm templaterenders correctlyterraform validatepassesterraform planshows expected changes