fix(mesh-values): high-entropy JWT secrets for the #1829 startup gate#170
Merged
Conversation
…#1829 startup gate The backend (artifact-keeper#1829) rejects low-entropy JWT secrets at startup (>=32 chars, >=16 distinct chars). The mesh overlays used 'mesh-test-jwt-main' and 'mesh-test-jwt-peer' (18 chars, 10-11 distinct), so the mesh backends crash-loop with 'JWT_SECRET is unsuitable: low entropy' and the release-gate mesh-tests job fails. Replace with high-entropy non-production test secrets (distinct main vs peer preserved).
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34021147 | Triggered | Generic High Entropy Secret | be54bb2 | charts/artifact-keeper/values-mesh-peer.yaml | View secret |
| 34021148 | Triggered | Generic High Entropy Secret | be54bb2 | charts/artifact-keeper/values-mesh-main.yaml | View secret |
| 34032178 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 34032178 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 34032179 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 34032179 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 34032178 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 34032178 | Triggered | Generic High Entropy Secret | 92a4f5d | charts/artifact-keeper/ci/test-values.yaml | View secret |
| 34032179 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 29340989 | Triggered | Generic Password | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 34032178 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 29340989 | Triggered | Generic Password | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 34032179 | Triggered | Generic High Entropy Secret | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 29340989 | Triggered | Generic Password | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
| 29340989 | Triggered | Generic Password | 92a4f5d | .github/workflows/helm-ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Missing linked issueThis PR does not reference a tracking issue in its body. Every PR must link to an issue in this repository so we can trace work back to a planned change. How to fix
Accepted keywords (case-insensitive, any tense): Policy reference: see the PR template. Maintainer bypass: apply the |
The install-test/helm-ci matrix used --set secrets.jwtSecret=ci-test (7 chars) and ci/test-values.yaml used 'ci-test-jwt-secret' (18 chars), both of which the backend now rejects at startup (#1829 requires >=32 chars, >=16 distinct). Use a high-entropy, helm/shell-safe non-production value across helm-ci.yml and ci/test-values.yaml; bump the meilisearch master key to >=16 bytes while here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backend (artifact-keeper#1829) rejects low-entropy JWT secrets at startup in all environments (needs ≥32 chars and ≥16 distinct chars). The mesh overlays use
mesh-test-jwt-main/mesh-test-jwt-peer(18 chars, 10–11 distinct), so the mesh backends crash-loop withJWT_SECRET is unsuitable: low entropyand the release-gate mesh-tests job fails.Fix
Replace both with high-entropy, clearly non-production test secrets (distinct main vs peer preserved). Companion fix for the single-instance test overlays is in artifact-keeper-test#224.